sql: clear (rather than emptying) bound account #71280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty() leaves some number of bytes in the bound account as reserved. When we abandon a Container, those "reserved" bytes were never released back to the parent. I believe we currently abandon one Container at the end of each explicit transaction. Release note: None
|
This change is |
miretskiy
approved these changes
Oct 7, 2021
| @@ -636,7 +636,7 @@ func (s *Container) freeLocked(ctx context.Context) { | |||
| atomic.AddInt64(s.atomic.uniqueStmtFingerprintCount, int64(-len(s.mu.stmts))) | |||
| atomic.AddInt64(s.atomic.uniqueTxnFingerprintCount, int64(-len(s.mu.txns))) | |||
|
|
|||
| s.mu.acc.Empty(ctx) | |||
| s.mu.acc.Clear(ctx) | |||
Azhng
approved these changes
Oct 7, 2021
There was a problem hiding this comment.
Ah good catch!
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @miretskiy and @stevendanna)
|
Though I think #65279 is probably unrelated since it's from way back in May, the offending PR was merged last night |
Unfortunately, the way the reporting works, the new failure because of the memory pressure just got added as a comment to the previous issue. |
|
Ah, that was unfortunate 😢 |
|
bors r=[Azhng,miretskiy] |
This was referenced Oct 7, 2021
Closed
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty() leaves some number of bytes in the bound account as
reserved. When we abandon a Container, those "reserved" bytes were
never released back to the parent. I believe we currently abandon one
Container at the end of each explicit transaction.
Fixes #71262
Fixes #71263
Fixes #71264
Fixes #65279
We may want to provide two different methods. One that calls Empty() and one that
calls Clear() in case there are users of this who really need to keep their reserved bytes.
Release note: None