Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterversion: introduce 22.1 development versions #71836

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

celiala
Copy link
Collaborator

@celiala celiala commented Oct 21, 2021

Fix: #69828

Looking at past Version values for Start{XX_X}, I think the Version value for Key: Start22_1 should instead be Major: 21, Minor: 2, ....

Start21_1 (from #70268):

// v21.1 versions. Internal versions defined here-on-forth must be even.
{
  Key:     Start21_1,
  Version: roachpb.Version{Major: 20, Minor: 2, Internal: 2},
},

Start 21_2:

{
  Key:     Start21_2,
  Version: roachpb.Version{Major: 21, Minor: 1, Internal: 1102},
},

Release justification: Non-production code change.
Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

{
Key: Start22_1,
Version: roachpb.Version{Major: 22, Minor: 1, Internal: 100},
Version: roachpb.Version{Major: 21, Minor: 2, Internal: 100},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the Internal counter start at 2? The 100 was just an artifact from last release.

Copy link
Collaborator Author

@celiala celiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @irfansharif)

a discussion (no related file):
TFTR!



pkg/clusterversion/cockroach_versions.go, line 512 at r1 (raw file):

Previously, irfansharif (irfan sharif) wrote…

Can we make the Internal counter start at 2? The 100 was just an artifact from last release.

Done.

Release justification: Non-production code change.
Release note: None
@celiala
Copy link
Collaborator Author

celiala commented Oct 22, 2021

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 22, 2021

Build succeeded:

@craig craig bot merged commit df06437 into cockroachdb:master Oct 22, 2021
@celiala celiala deleted the introduce-22.1 branch April 5, 2022 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants