-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clusterversion: introduce 22.1 development versions #71836
Conversation
{ | ||
Key: Start22_1, | ||
Version: roachpb.Version{Major: 22, Minor: 1, Internal: 100}, | ||
Version: roachpb.Version{Major: 21, Minor: 2, Internal: 100}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make the Internal counter start at 2? The 100 was just an artifact from last release.
c3fc2e9
to
cd54ef1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @irfansharif)
a discussion (no related file):
TFTR!
pkg/clusterversion/cockroach_versions.go, line 512 at r1 (raw file):
Previously, irfansharif (irfan sharif) wrote…
Can we make the Internal counter start at 2? The 100 was just an artifact from last release.
Done.
cd54ef1
to
20521e0
Compare
Release justification: Non-production code change. Release note: None
20521e0
to
3b3bec8
Compare
TFTR! bors r+ |
Build succeeded: |
Fix: #69828
Looking at past Version values for
Start{XX_X}
, I think theVersion
value forKey: Start22_1
should instead beMajor: 21, Minor: 2, ...
.Start21_1 (from #70268):
Start 21_2:
Release justification: Non-production code change.
Release note: None