Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachprod: configure logging in roachprod library #74223

Merged
merged 1 commit into from
Dec 23, 2021

Commits on Dec 23, 2021

  1. roachprod: configure logging in roachprod library

    This patch moves `pkg/cmd/roachtest/logger` to `pkg/roachprod/logger`
    to be used as a logger by the roachprod library. `roachtest` and the
    roachprod binary are then configured to use/pass instances of `logger`
    as needed by `pkg/roachprod`.
    
    All calls to `fmt.Printf` and `fmt.Println` were removed from
    `pkg/roachprod` except in few cases specific to the roachprod
    binary. In the future, using `fmt.Printf` and `fmt.Println` in
    the library (i.e. `pkg/roachprod`) should be discouraged.
    
    Release note: None
    Ahmad Abedalqader authored and rickystewart committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    21a286f View commit details
    Browse the repository at this point in the history