sql: refactor ConcurrentWriteBuffer into ConcurrentBufferGuard #75176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Jan 19, 2022
Azhng
force-pushed
the
txn-id-guard
branch
4 times, most recently
from
17d84d5
to
db66b10
Compare
This commit refactors the pattern used in ConcurrentWriterBuffer used in transaction ID cache into a generic helper data structure to allow for future reuse. Partially address cockroachdb#74487 Release note: None
maryliag
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Reviewed 3 of 34 files at r6, 4 of 4 files at r7, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the pattern used in ConcurrentWriterBuffer used in
transaction ID cache into a generic helper data structure to allow for
future reuse.
Partially address #74487
Release note: None