Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: bump Pebble to 38b68e17aa97 #75845

Merged

Conversation

nicktrav
Copy link
Collaborator

@nicktrav nicktrav commented Feb 2, 2022

Pebble commits:

38b68e17 internal/batchskl: return error on index overflow
8440f290 internal/manifest: use a line sweep to optimize NewL0Sublevels
0f5acb26 sstable: add direct block reading to suffix rewriter
26856d10 db: avoid stats flake in TestMemTableReservation
b452808f sstable: Make sstable Writer.Close idempotent
17fe1a65 sstable: add RewriteKeySuffixes function
c9e6edfc db: expose metrics on count and earliest seqnum of snapshots
b958d9a7 sstable: add a writeQueue to the sstable writer
c8dad06c db: disable automatic compactions in `MetricsTest`
015f5e38 internal/rangekey: fix range key iteration bug

The commit 38b68e17 contains the fix for #69906.

Closes #69906.

Release note: none

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @itsbilal)

@nicktrav
Copy link
Collaborator Author

nicktrav commented Feb 2, 2022

TFTR!

bors r=jbowens

@nicktrav nicktrav force-pushed the nickt/pebble-master-38b68e17aa97 branch from dd277c5 to ed343ba Compare February 2, 2022 18:36
@craig
Copy link
Contributor

craig bot commented Feb 2, 2022

Canceled.

@nicktrav
Copy link
Collaborator Author

nicktrav commented Feb 2, 2022

Picked up a merge conflict. Rebased.

bors r=jbowens

Pebble commits:

```
38b68e17 internal/batchskl: return error on index overflow
8440f290 internal/manifest: use a line sweep to optimize NewL0Sublevels
0f5acb26 sstable: add direct block reading to suffix rewriter
26856d10 db: avoid stats flake in TestMemTableReservation
b452808f sstable: Make sstable Writer.Close idempotent
17fe1a65 sstable: add RewriteKeySuffixes function
c9e6edfc db: expose metrics on count and earliest seqnum of snapshots
b958d9a7 sstable: add a writeQueue to the sstable writer
c8dad06c db: disable automatic compactions in `MetricsTest`
015f5e38 internal/rangekey: fix range key iteration bug
```

The commit 38b68e17 contains the fix for cockroachdb#69906.

Closes cockroachdb#69906.

Release note: none
@nicktrav nicktrav force-pushed the nickt/pebble-master-38b68e17aa97 branch from ed343ba to 13694f6 Compare February 2, 2022 18:37
@craig
Copy link
Contributor

craig bot commented Feb 2, 2022

Canceled.

@nicktrav
Copy link
Collaborator Author

nicktrav commented Feb 2, 2022

bors r=jbowens

@craig
Copy link
Contributor

craig bot commented Feb 2, 2022

Build succeeded:

@craig craig bot merged commit 88522a3 into cockroachdb:master Feb 2, 2022
@nicktrav nicktrav deleted the nickt/pebble-master-38b68e17aa97 branch February 2, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pebble: v20.2.4: index out of range (looks like an integer overflow)
3 participants