Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: update SHOW GRANTS ON DATABASE to include grant options #75854

Merged
merged 1 commit into from
Feb 3, 2022
Merged

sql: update SHOW GRANTS ON DATABASE to include grant options #75854

merged 1 commit into from
Feb 3, 2022

Conversation

ecwall
Copy link
Contributor

@ecwall ecwall commented Feb 2, 2022

refs #73394

Release note (sql): SHOW GRANTS ON DATABASE includes is_grantable column

@ecwall ecwall requested review from rafiss, otan, RichardJCai, a team and shermanCRL and removed request for a team February 2, 2022 13:16
@cockroach-teamcity
Copy link
Member

This change is Reviewable

refs #73394

Release note (sql): SHOW GRANTS ON DATABASE includes is_grantable column
@shermanCRL shermanCRL requested review from msbutler and removed request for shermanCRL February 2, 2022 14:49
Copy link
Contributor

@RichardJCai RichardJCai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 12 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @msbutler, @otan, and @rafiss)

@ecwall
Copy link
Contributor Author

ecwall commented Feb 2, 2022

bors r=RichardJCai

@craig
Copy link
Contributor

craig bot commented Feb 2, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 3, 2022

Build failed (retrying...):

@craig craig bot merged commit 7499c27 into cockroachdb:master Feb 3, 2022
@craig
Copy link
Contributor

craig bot commented Feb 3, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants