changefeedccl: set server.child_metrics.enabled public column to true #77561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
column to true Since we're expecting people to use this setting to use metrics labels, it should show up when running SHOW ALL CLUSTER SETTINGS. Release note (enterprise change): The public column of setting server.child_metrics.enabled will be set to true. Release justification: This change is very small and low risk
|
This change is |
HonoreDB
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @sherman-grewal)
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changefeedccl: set server.child_metrics.enabled public column
to true
Resolves #77536
Since we're expecting people to use this setting to
use metrics labels, it should show up when running SHOW
ALL CLUSTER SETTINGS.
Release note (enterprise change): The public column
of setting server.child_metrics.enabled will be set
to true.
Release justification: This change is very small and low
risk