Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: support virtual table indexes with generators #80422

Merged
merged 1 commit into from
May 6, 2022

Commits on Apr 25, 2022

  1. sql: support virtual table indexes with generators

    While previously virtual schema tables had support for defining tables
    with a `populate` function, which eagerly loads all rows, or a
    `generator` function, which lazy loads each row when called (possibly
    running in a worker Goroutine), and also had support for virtual indexes
    which would have their own `populate` functions, there was a subtle lack
    of support for using virtual indexes with virtual tables that used a
    `generator`, since the virtual index constraint logic would fall back to
    a (possibly undefined) `populate` function in several cases. This change
    fixes the nil pointer exception that could occur if using virtual
    indexes with a table using a `generator`, and validates that the virtual
    index is supported prior to use.
    
    Release note: None
    AlexTalks committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    622be5c View commit details
    Browse the repository at this point in the history