tree: remove roachpb references

[otan]

See individual commits for details.

[cockroach-teamcity]

This change is 

[ajwerner]

Reviewed 5 of 5 files at r1, 2 of 2 files at r2, 7 of 7 files at r3.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @ajwerner, @msbutler, and @otan)

---

pkg/sql/sem/tree/tenant.go line 29 at r1 (raw file):

	// TODO(knz): None of this complexity would be needed if the tenant
	// ID was specified using an Expr here. This can be removed once the
	// backup target syntax accepts expressions for tenant targets.

this comment is pretty stale now given we really actively rely on Specified and it's not "extra complexity"

Code quote:

	// Specified is set to true when the TENANT clause was specified in
	// the backup target input syntax. We need this, instead of relying
	// on TenantID.IsSet(), because we need a special marker for
	// the case when the value was anonymized. In other places, the
	// value used for anonymized integer literals is 0, but we can't use
	// 0 for TenantID as this is refused during parsing, nor can we use
	// any other value since all non-zero integers are valid tenant IDs.
	//
	// TODO(knz): None of this complexity would be needed if the tenant
	// ID was specified using an Expr here. This can be removed once the
	// backup target syntax accepts expressions for tenant targets.

---

pkg/sql/sem/tree/tenant.go line 37 at r1 (raw file):

// IsSet returns whether the TenantID is set.
func (t *TenantID) IsSet() bool {
	return t.ID != 0

:/ See the above comment, I think we instead need to look at Specified in some cases?

[otan]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @ajwerner and @msbutler)

---

pkg/sql/sem/tree/tenant.go line 29 at r1 (raw file):

Previously, ajwerner wrote…

this comment is pretty stale now given we really actively rely on Specified and it's not "extra complexity"

i've removed the TODO

---

pkg/sql/sem/tree/tenant.go line 37 at r1 (raw file):

Previously, ajwerner wrote…

:/ See the above comment, I think we instead need to look at Specified in some cases?

i was just basing this on old logic (it fell to roachpb.TenantID.IsSet). Happy to chuck in a t.Specified here as well.

[otan]

had to drop the last commit for now

$ bazel query 'somepath(//pkg/sql/sem/tree:tree, //pkg/roachpb:roachpb)'
//pkg/sql/sem/tree:tree
//pkg/security:security
//pkg/clusterversion:clusterversion
//pkg/roachpb:roachpb

[ajwerner]

Reviewed 1 of 11 files at r5, 2 of 2 files at r6, 7 of 7 files at r7, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @msbutler)

[irfansharif]

Looks like the PR was able to break the dependency between pkg/sql/parser and pkg/roachpb; so we can remove this fellow:

cockroach/pkg/sql/parser/BUILD.bazel

Line 25 in e0ec899

"//pkg/roachpb", # keep

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @msbutler)

[otan]

There is still a path to roachpb indirectly but Andrew is removing that.

[otan]

bors r=ajwerner

[craig]

Build failed:

• GitHub CI (Cockroach)

[otan]

bors r=ajwerner

[craig]

Build succeeded:

• GitHub CI (Cockroach)