opt: break memo's dependence on builtins #80745
Conversation
|
This change is |
There was a problem hiding this comment.
nit: add "Informs #79357"
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner and @yuzefovich)
-- commits line 4 at r1:
nit: packages -> package's
mgartner
force-pushed
the
break-memo-dep-on-builtins
branch
from
8e91a61
to
e3e8277
Compare
There was a problem hiding this comment.
Done.
Reviewable status:
Previously, rytaft (Rebecca Taft) wrote…
nit: packages -> package's
Done.
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
There was a problem hiding this comment.
Looks like you need to run ./dev gen bazel so that the disallowed imports test is included in the bazel targets.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:
mgartner
force-pushed
the
break-memo-dep-on-builtins
branch
from
e3e8277
to
2090719
Compare
This commit breaks the `memo` package's dependence on the `builtins` package so that they can be compiled concurrently. Optimizer packages are no longer on the critical path, for now. Informs cockroachdb#79357 Release note: None
mgartner
force-pushed
the
break-memo-dep-on-builtins
branch
from
2090719
to
4287c44
Compare
|
TFTRs! bors r+ |
|
Build succeeded: |
This commit breaks the
memopackages dependence on thebuiltinspackage so that they can be compiled concurrently. Optimizer packages
are no longer on the critical path, for now.
Informs #79357
Release note: None