Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.1: kvclient: fix gRPC stream leak in rangefeed client #80795

Merged
merged 1 commit into from
May 4, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 29, 2022

Backport 1/1 commits from #80705 on behalf of @erikgrinaker.

/cc @cockroachdb/release


When the DistSender rangefeed client received a RangeFeedError message
and propagated a retryable error up the stack, it would fail to close
the existing gRPC stream, causing stream/goroutine leaks.

Release note (bug fix): Fixed a goroutine leak when internal rangefeed
clients received certain kinds of retriable errors.


Release justification: fixes a resource leak.

@blathers-crl blathers-crl bot requested a review from a team as a code owner April 29, 2022 16:11
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-21.1-80705 branch from 2e14089 to 0ca8708 Compare April 29, 2022 16:11
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 29, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from tbg April 29, 2022 16:11
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 29, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

When the DistSender rangefeed client received a `RangeFeedError` message
and propagated a retryable error up the stack, it would fail to close
the existing gRPC stream, causing stream/goroutine leaks.

Release note (bug fix): Fixed a goroutine leak when internal rangefeed
clients received certain kinds of retriable errors.
@erikgrinaker erikgrinaker force-pushed the blathers/backport-release-21.1-80705 branch from 0ca8708 to 8bbe1fc Compare May 4, 2022 13:21
@erikgrinaker erikgrinaker merged commit bf2bef1 into release-21.1 May 4, 2022
@erikgrinaker erikgrinaker deleted the blathers/backport-release-21.1-80705 branch May 4, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants