Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hlc: move ParseHLC / DecimalToHLC to util/hlc #80892

Merged
merged 1 commit into from
May 3, 2022

Conversation

otan
Copy link
Contributor

@otan otan commented May 2, 2022

util/hlc needs util/log, but ParseHLC/DecimalToHLC doesn't need to be
in tree. To remove the tree dependency on util/log, move the
mentioned functions.

Release note: None

@otan otan requested a review from ajwerner May 2, 2022 22:36
@otan otan requested review from a team as code owners May 2, 2022 22:36
@otan otan requested a review from a team May 2, 2022 22:36
@otan otan requested a review from a team as a code owner May 2, 2022 22:36
@cockroach-teamcity
Copy link
Member

This change is Reviewable

util/hlc needs util/log, but ParseHLC/DecimalToHLC doesn't need to be
in tree. To remove the tree dependency on util/log, move the
mentioned functions.

Release note: None
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 22 of 22 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @otan)

@otan
Copy link
Contributor Author

otan commented May 3, 2022

bors r=ajwerner

@craig
Copy link
Contributor

craig bot commented May 3, 2022

Build succeeded:

@craig craig bot merged commit 91aa127 into cockroachdb:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants