Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl/backupccl: do not backup spans for views #85158

Merged
merged 1 commit into from
Aug 20, 2022

Conversation

rhu713
Copy link
Contributor

@rhu713 rhu713 commented Jul 27, 2022

Backups currently backup spans corresponding to views. These spans should not
be backed up as they do not contain data.

Additionally, because we do not split ranges at view boundaries, it is possible
that the range the view span belongs to is shared by another object in the
cluster (that we may or may not be backing up) that might have its own bespoke
zone configurations, namely one with a short GC TTL. This could lead to a
situation where the short GC TTL on the range we are not backing up causes our
protectedts verification to fail when attempting to backup the view span.

Release note (bug fix): Fix a bug in backup where spans for views were being
backed up. Because ranges are not split at view boundaries, this can cause the
backup to send export requests to ranges that do not belong to any backup
target.

Release justification: bug fixes and low-risk updates to new functionality

@rhu713 rhu713 requested review from a team and msbutler July 27, 2022 19:48
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rhu713 rhu713 requested review from adityamaru and removed request for msbutler July 27, 2022 19:52
@rhu713
Copy link
Contributor Author

rhu713 commented Jul 27, 2022

Basically the same change as #66072, but I don't think it was ever merged to master.

pkg/ccl/backupccl/backup_planning.go Show resolved Hide resolved
pkg/ccl/backupccl/backup_test.go Outdated Show resolved Hide resolved
pkg/ccl/backupccl/backup_test.go Outdated Show resolved Hide resolved
@adityamaru adityamaru self-requested a review July 27, 2022 21:12
@rhu713 rhu713 force-pushed the view-backup-spans branch 2 times, most recently from 66136e2 to c0eebb5 Compare August 18, 2022 18:05
Backups currently backup spans corresponding to views. These spans should not
be backed up as they do not contain data.

Additionally, because we do not split ranges at view boundaries, it is possible
that the range the view span belongs to is shared by another object in the
cluster (that we may or may not be backing up) that might have its own bespoke
zone configurations, namely one with a short GC TTL. This could lead to a
situation where the short GC TTL on the range we are not backing up causes our
protectedts verification to fail when attempting to backup the view span.

Release note (bug fix): Fix a bug in backup where spans for views were being
backed up. Because ranges are not split at view boundaries, this can cause the
backup to send export requests to ranges that do not belong to any backup
target.

Release justification: bug fixes and low-risk updates to new functionality
@rhu713
Copy link
Contributor Author

rhu713 commented Aug 19, 2022

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 19, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 19, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 20, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 20, 2022

Build succeeded:

@craig craig bot merged commit cb55144 into cockroachdb:master Aug 20, 2022
@blathers-crl
Copy link

blathers-crl bot commented Aug 20, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 92397cc to blathers/backport-release-21.1-85158: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.1.x failed. See errors above.


error creating merge commit from 92397cc to blathers/backport-release-21.2-85158: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.


error creating merge commit from 92397cc to blathers/backport-release-22.1-85158: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants