util/log: rework eventpb so that log does not depend on it #85643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
force-pushed
the
ajwerner/break-log-eventpb-dep
branch
from
52c98bc
to
dd9d84b
Compare
ajwerner
force-pushed
the
ajwerner/break-log-eventpb-dep
branch
from
dd9d84b
to
7eae1a3
Compare
ajwerner
force-pushed
the
ajwerner/break-log-eventpb-dep
branch
2 times, most recently
from
d63ce42
to
c69df3e
Compare
knz
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
Reviewed 66 of 66 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajwerner and @msbutler)
pkg/util/log/eventpb/events.go line 82 at r1 (raw file):
var _ EventWithCommonSchemaChangePayload = (*FinishSchemaChange)(nil) var _ EventWithCommonSchemaChangePayload = (*ReverseSchemaChange)(nil) var _ EventWithCommonSchemaChangePayload = (*FinishSchemaChangeRollback)(nil)
Where are these interface assertions moved to?
ajwerner
force-pushed
the
ajwerner/break-log-eventpb-dep
branch
from
c69df3e
to
523de4c
Compare
|
Thanks for the review!
Removed by accident. Added them back. |
ajwerner
force-pushed
the
ajwerner/break-log-eventpb-dep
branch
from
523de4c
to
ade283c
Compare
This commit reworks some code generation and dependencies such that eventpb now depends on logpb and log no longer needs to depend on eventpb. This is important so that we can import protocol buffers into eventpb from other protobuf packages like descpb and hlc which themselves import util/log. Realistically it's bad that those packages import log, but this was easier to break in a sense than was that, and this is also a sane depedendency to not have. Release note: None
ajwerner
force-pushed
the
ajwerner/break-log-eventpb-dep
branch
from
ade283c
to
847fddd
Compare
|
bors r=knz |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reworks some code generation and dependencies such that eventpb
now depends on logpb and log no longer needs to depend on eventpb. This is
important so that we can import protocol buffers into eventpb from other
protobuf packages like descpb and hlc which themselves import util/log.
Realistically it's bad that those packages import log, but this was easier
to break in a sense than was that, and this is also a sane depedendency to
not have.
Release note: None