roachprod: set default cluster settings when starting

[renatolabs]

In #88514, the cluster start logic was refactored to reuse the same code across init and start, fixing a bug in the former. However, the refactoring overlooked the fact that we previously always set the default cluster settings when there's more than one node in the cluster.

This fixes that by setting the default cluster settings in that case; one particularly important cluster setting is the license key, necessary for some roachtests.

Fixes #88660
Fixes #88665
Fixes #88666
Fixes #88710.

Release note: None

[cockroach-teamcity]

This change is 

[yuzefovich]

Thanks!

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @herkolategan and @renatolabs)

---

-- commits line 2 at r1:
nit: no trailing periods in the commit message titles.

---

-- commits line 14 at r1:
nit: this will only close the first issue - you need to put each issue on a separate line with its own "Fixes" prefix.

[smg260]

LGTM,

nit: I notice initializeCluster is followed by setClusterSettings twice - if this is a common pattern, might it make sense to abstract away into a function which does both?

[srosenberg]

nit: I notice initializeCluster is followed by setClusterSettings twice - if this is a common pattern, might it make sense to abstract away into a function which does both?

Right. Technically, it's called twice only on the first node (i.e., n1), when numNodes > 1. I think setClusterSettings is idempotent and side-effect free (?).

[srosenberg]

nit: I notice initializeCluster is followed by setClusterSettings twice - if this is a common pattern, might it make sense to abstract away into a function which does both?

Right. Technically, it's called twice only on the first node (i.e., n1), when numNodes > 1. I think setClusterSettings is idempotent and side-effect free (?).

Nope. It's invoked at most once on each node. In case of single-node clusters which are started via start-single-node, initializeCluster is skipped because that's done elsewhere, but setClusterSettings is still needed.

[renatolabs]

Yes. clusterSynced.Init is the function that calls them both. Start's behavior a little tricky:

• don't initialize nor set default cluster settings if --skip-init was passed
• don't initialize but set cluster settings if starting with more than one node (not start-single-node)
• do both otherwise.

#88514 broke that because of I misread the meaning of the shouldInit local variable. We should have restored the previous behavior now.

[renatolabs]

bors r=yuzefovich,srosenberg,smg260

TFTRs!

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)