tree: fix internal error comparing tuple type with non-tuple type #92635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msirek
force-pushed
the
catchUnsupportedComparison
branch
from
162b4c5
to
5f2b661
Compare
|
Maybe hold off on review... a few changes coming. |
msirek
force-pushed
the
catchUnsupportedComparison
branch
from
5f2b661
to
9ad8a6f
Compare
rytaft
reviewed
Nov 29, 2022
|
Consider adding a backport label for 22.2 and 22.1 |
Fixes cockroachdb#91532 This fixes comparison of an empty tuple expression, ROW() or (), or a non-empty tuple expression with a non-tuple type by returning an error message instead of an internal error. Release note (bug fix): This fixes an internal error when comparing a tuple type with a non-tuple type.
msirek
force-pushed
the
catchUnsupportedComparison
branch
from
9ad8a6f
to
7b473a8
Compare
|
TFTRs! |
|
Build succeeded: |
This was referenced Nov 30, 2022
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91532
This fixes comparison of an empty tuple expression, ROW() or (), or
a non-empty tuple expression with a non-tuple type by returning
an error message instead of an internal error.
Release note (bug fix): This fixes an internal error when comparing
a tuple type with a non-tuple type.