kvserver: minor test cleanup #93363
Merged
kvserver: minor test cleanup #93363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was uselessly looking at the cancelation of an uncancellable context. Release note: None Epic: None
|
This change is |
This test was jumping through hoops in order to combine a cluster stopper, with its own Tracer, with calling into a node, which has a different Tracer. Normally combining Tracers like that is illegal, but the test was making sure to force the Stopper to create "sterile" spans for its tasks, which are exempt from this restriction about combining them with other Tracers, for arcane reasons. This patch switches the test to a more straight-forward hoop: don't use a context created by the stopper when calling into the node. Besides being simpler, this is needed cause the exception for sterile spans is going away. Release note: None Epic: None
andreimatei
commented
Dec 13, 2022
There was a problem hiding this comment.
friendly ping
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @tbg)
tbg
approved these changes
Dec 14, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.