sql: make SHOW RANGES FOR TABLE include all indexes #93545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
I'm waiting for CI to tell me where to put it :) |
knz
force-pushed
the
20221213-show-ranges
branch
2 times, most recently
from
6f5b42e
to
e65e84a
Compare
Release note (backward-incompatible change): `SHOW RANGES FOR TABLE` now includes rows for all indexes that support the table. Prior to this change, `SHOW RANGES FOR TABLE foo` was an alias for `SHOW RANGES FOR INDEX foo@primary`. This was causing confusion, as it would miss data for secondary indexes. It is still possible to filter to just the primary index using `SHOW RANGES FOR INDEX foo@primary`. The statement output now also includes the index name.
knz
force-pushed
the
20221213-show-ranges
branch
from
e65e84a
to
5604fea
Compare
|
bors r=ajwerner |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #80906.
Fixes #93546.
Fixes #82995.
Epic: CRDB-22701
Release note (backward-incompatible change):
SHOW RANGES FOR TABLEnow includes rows for all indexes that support the table. Prior to
this change,
SHOW RANGES FOR TABLE foowas an alias forSHOW RANGES FOR INDEX foo@primary. This was causing confusion, as it would missdata for secondary indexes. It is still possible to filter to just the
primary index using
SHOW RANGES FOR INDEX foo@primary.The statement output now also includes the index name.