upgrades: fix desc ID sequence definition to match expectation #93610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Before this change, the test fails with:
```
Diff:
@@ -29,11 +29,11 @@
"lastUpdated" TIMESTAMP NOT NULL DEFAULT now():::TIMESTAMP,
"valueType" STRING NULL,
CONSTRAINT "primary" PRIMARY KEY (name ASC),
FAMILY "fam_0_name_value_lastUpdated_valueType" (name, value, "lastUpdated", "valueType")
);
-CREATE SEQUENCE public.descriptor_id_seq MINVALUE 1 MAXVALUE 9223372036854775807 INCREMENT 1 START 1;
+CREATE SEQUENCE public.descriptor_id_seq MINVALUE 1 MAXVALUE 9223372036854775807 INCREMENT 1 START 104;
CREATE TABLE public.tenants (
id INT8 NOT NULL,
active BOOL NOT NULL DEFAULT true,
info BYTES NULL,
name STRING NULL AS (crdb_internal.pb_to_json('cockroach.sql.sqlbase.TenantInfo':::STRING, info)->>'name':::STRING) VIRTUAL,
----
```
This was revealed by cockroachdb#93487 which fixed the broken roachtest. Expect a few more
of these.
Fixes: cockroachdb#93602
Release note: None
ajwerner
force-pushed
the
ajwerner/fix-systemschemavalidation-on-master
branch
from
570b8dd
to
691e50b
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the test fails with:
This was revealed by #93487 which fixed the broken roachtest. Expect a few more of these.
Fixes: #93602
Release note: None