Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: move a logstorage portion of applySnapshot to kvstorage #93904

Closed
wants to merge 4 commits into from

Conversation

tbg
Copy link
Member

@tbg tbg commented Dec 19, 2022

This sits on top of #94201.


This is partial work - there are more interactions with the log engine
when removing subsumed replicas. This commit is mostly mechanical
copy-paste with some adjustments to get it to compile again.

The tricky part is teasing apart replica subsumption. This is not attempted
here yet.

Touches #93900.

Epic: CRDB-220
Release Note: none

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg tbg marked this pull request as ready for review December 19, 2022 14:00
@tbg tbg requested a review from a team as a code owner December 19, 2022 14:00
@tbg tbg requested a review from a team December 19, 2022 14:00
@tbg tbg marked this pull request as draft December 19, 2022 14:00
@tbg tbg mentioned this pull request Dec 19, 2022
Base automatically changed from kvstorage to master December 20, 2022 12:06
@tbg tbg force-pushed the logstore-sst-93900 branch 3 times, most recently from a15162a to e0241fb Compare January 10, 2023 16:00
This is partial work - there are more interactions with the log engine
when removing subsumed replicas. This commit is mostly mechanical
copy-paste with some adjustments to get it to compile again.

Touches #93900.

Epic: CRDB-220
Release note: None
Epic: none
Release note: None
@tbg tbg closed this Jan 30, 2023
@mgartner mgartner deleted the logstore-sst-93900 branch May 23, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants