ui: remove timeScale update from fingerprint details link from insight details #98143
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ericharmeling)
-- commits line 4 at r1:
I would change to "part of" because you won't be able to backport this and the change is different for 22.2, so once you have that in it can be consider "fixed"
Also, the same thing happens on Transaction Insights, so this change should also happen there.
Can you confirm that clicking on fingerprint id from the insights overview page is also working (not just clicking from the insights details page)
…t details Part of cockroachdb#97952. This commit removes the setTimeScale call from the StatementDetailsLink and TransactionDetailsLink functions. Navigating to the Fingerprint Details pages from the Insights Details pages will no longer set the global time scale. Epic: none Release note: None
ericharmeling
force-pushed
the
rm-stmt-details-link-ts-update
branch
from
4b95c34
to
e3ceb51
Compare
ericharmeling
changed the title
There was a problem hiding this comment.
Reviewable status:
I would change to "part of" because you won't be able to backport this and the change is different for 22.2, so once you have that in it can be consider "fixed"
Done.
Also, the same thing happens on Transaction Insights, so this change should also happen there.
Done.
Can you confirm that clicking on fingerprint id from the insights overview page is also working (not just clicking from the insights details page)
Done. Updated the loom videos.
There was a problem hiding this comment.
Nice!
Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status:
|
bors r+ |
|
Build succeeded: |
Part of #97952.
This PR removes the setTimeScale call from the StatementDetailsLink
and TransactionDetailsLink functions. Navigating to the Fingerprint Details
pages from the Insights Details pages will no longer set the global time scale.
Loom (CC Console): https://www.loom.com/share/ca388c8c0068446d960f89cc6c1f6af5
Loom (DB Console): https://www.loom.com/share/209f2d21a1784d1d86adffabddb9b47f
Epic: none
Release note: None