Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: Add pg_indexes table to pg_catalog #9869

Merged

Conversation

nvanbenschoten
Copy link
Member

@nvanbenschoten nvanbenschoten commented Oct 11, 2016

The pg_indexes table provides access to useful information about each
index in the database.


This change is Reviewable

@knz
Copy link
Contributor

knz commented Oct 12, 2016

:lgtm:

However I start to perceive some feature duplication between this and the various SHOW CREATE implementations. I think time has now come to file an issue to replace our current implementation of SHOW by one which substitutes SHOW nodes with the appropriate SELECT on virtual tables. Could you file this issue?


Reviewed 4 of 4 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

The pg_indexes table provides access to useful information about each
index in the database.
@nvanbenschoten
Copy link
Member Author

Done #9966.


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@nvanbenschoten nvanbenschoten merged commit c51e9ae into cockroachdb:master Oct 14, 2016
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/morePgCat branch October 14, 2016 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants