-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Docker startup steps #9216
Conversation
@jbowens I went as far back as 19.2 to make this fix, but let know if that wasn't necessary. Also, these articles are used in our Linux tutorials (e.g. https://www.cockroachlabs.com/docs/v20.2/start-a-local-cluster-in-docker-linux) as well. Can the same updates apply to Linux, or should we break this out into a Mac-specific article? |
Looks good! I think it's good idea to make the change all the way back to 19.2.
Yeah, that seems fine to recommend the same for Linux. I think one more thing we should change is Step 6: Stop the cluster. Instead of telling them to
|
TFTR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @mikeCRL)
@taroface, I'll go ahead and merge this. If there's any work left, you can follow-up with another PR. |
Fixes #9185.