Use cockroach workload in deployment tutorials #9834
Conversation
|
This change is |
jseldess
force-pushed
the
deployment-built-in-workloads
branch
from
b9127bc
to
cd6e153
Compare
There was a problem hiding this comment.
LGTM with one wording suggestion! Thank you for this update.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jseldess)
_includes/v20.2/prod-deployment/insecure-test-load-balancing.md, line 4 at r1 (raw file):
{{site.data.alerts.callout_info}} Be sure that you have set up an inbound rule that allows traffic from the application to the load balancer. In this case, you will run the sample workload on one of your machines. The traffic source for your inbound rule should therefore be the **internal (private)** IP address of that machine.
The phrase "set up an inbound rule" seems specific to AWS. Perhaps this should be a more generic "configured your network to allow traffic...". (Unfortunately, the "Configure your network" anchor is different on AWS vs. the other platforms, so we can't link back to it here.)
_includes/v20.2/prod-deployment/secure-test-load-balancing.md, line 4 at r1 (raw file):
{{site.data.alerts.callout_info}} Be sure that you have set up an inbound rule that allows traffic from the application to the load balancer. In this case, you will run the sample workload on one of your machines. The traffic source for your inbound rule should therefore be the **internal (private)** IP address of that machine.
Same comment as above.
_includes/v21.1/prod-deployment/insecure-test-load-balancing.md, line 4 at r1 (raw file):
{{site.data.alerts.callout_info}} Be sure that you have set up an inbound rule that allows traffic from the application to the load balancer. In this case, you will run the sample workload on one of your machines. The traffic source for your inbound rule should therefore be the **internal (private)** IP address of that machine.
Same comment as above.
_includes/v21.1/prod-deployment/secure-test-load-balancing.md, line 4 at r1 (raw file):
{{site.data.alerts.callout_info}} Be sure that you have set up an inbound rule that allows traffic from the application to the load balancer. In this case, you will run the sample workload on one of your machines. The traffic source for your inbound rule should therefore be the **internal (private)** IP address of that machine.
Same comment as above.
Instead of the distinct workload binary. Fixes #5359.
jseldess
force-pushed
the
deployment-built-in-workloads
branch
from
cd6e153
to
c1adbf6
Compare
There was a problem hiding this comment.
Reviewable status:
_includes/v20.2/prod-deployment/insecure-test-load-balancing.md, line 4 at r1 (raw file):
Previously, taroface (Ryan Kuo) wrote…
The phrase "set up an inbound rule" seems specific to AWS. Perhaps this should be a more generic "configured your network to allow traffic...". (Unfortunately, the "Configure your network" anchor is different on AWS vs. the other platforms, so we can't link back to it here.)
Done.
_includes/v20.2/prod-deployment/secure-test-load-balancing.md, line 4 at r1 (raw file):
Previously, taroface (Ryan Kuo) wrote…
Same comment as above.
Done.
_includes/v21.1/prod-deployment/insecure-test-load-balancing.md, line 4 at r1 (raw file):
Previously, taroface (Ryan Kuo) wrote…
Same comment as above.
Done.
_includes/v21.1/prod-deployment/secure-test-load-balancing.md, line 4 at r1 (raw file):
Previously, taroface (Ryan Kuo) wrote…
Same comment as above.
Done.
Instead of the distinct workload binary.
Fixes #5359.