forked from facebook/rocksdb
-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
util/crc32c: always compile FastCRC32 with SSE4.2 instructions
The use of this function is guarded by a CPUID check. That is, compiling this function with SSE4.2 crc32q instructions will never cause a SIGILL, even on CPUs that don't support SSE4.2, because the function can never be reached. The previous solution to enable hardware support for CRC32C required compiling all of RocksDB with `-msse4.2` or the equivalent. This gave the compiler permission to emit SSE4.2 instructions in functions that were not guarded by a CPUID check, resulting in SIGILLS on non-SSE4.2 CPUs.
- Loading branch information
Showing
1 changed file
with
5 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters