This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
upgrade lib/pq #58
Open
upgrade lib/pq #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9509dcb compaction: fix nil pointer during errored compactions d27f1d7 internal/base: add SetWithDelete key kind 971533d base: add `InternalKeyKindSeparator` 3f0c125 cmd/pebble: specify format major version
9656de4 db: write OPTIONS file to temporary path 558d587 internal/cache: prevent coldTarget from becoming greater than targetSize 634eb34 db: support nil logger in EventListener.EnsureDefaults d2266ba internal/cache: update entry size in the etTest to etHot transition
031921b4 metamorphic: add keyManager abstraction and SetWithDelete bug fix 3584eb6d internal/cache: recalculate hot, cold and test stats in metaCheck 20f0f9f7 internal/cache: include countCold and sizeCold in runHandCold stack traces 7992aeaa internal/cache: add hot, cold, test entry counts Release note: None
c7384149 ci: enable CI for release branches
dc6335d2 db: disable table stats by default in TestCompactionDeleteOnlyHints
676f3403 internal/metamorphic: prevent panic in restartDB command
b0adb48e db: set smallest / largest keys for elision-only compactions
7fdf1a3e pebble: make tableCacheOpts read-only
65413e86 db: clarify global seqnum comment within Ingest
9d7ee584 *: fix misspellings
82e8b76b internal/metamorphic: add cli to diff specific options outputs
ffdadc10 internal/base: split MakeFilename into MakeFile{path,name}
25846d19 modules: update golang.org/x/sys to fix panic on darwin with go1.17
59007c61 sstable: consolidate checksum types 17635b0a *: address staticcheck lints 11823273 *: address staticcheck lint check U1000 807abfe8 *: address staticcheck lint check S1039 d24dd342 all: remove some unused code 3bdca93a sstable: clarify comment on checksum input 926d23e9 pebble: remove comment related to batching from the table cache 0a6177ae db: tweak ErrClosed documentation ecc685b2 db: expose facility for retrieving batch count b2eb88a7 sstable: remove unused rawBlockIter err field
7fec828f db,sstable: block property collectors and filters f2339cc7 compaction: read compaction fixes e95e7374 pebble: add additional mechanism to schedule read compactions cdbcfe9f db: Expose logic to calculate the table cache size 0ee4290c db: schedule sstable validation on ingestion 543bc6fa db: use locked suffix for function names; simplify boolean expression 5393ca16 internal/rate: skip two flaky tests on darwin 7cd88488 sstable: print additional fields in verbose block layout 4f6402b1 *: enable staticcheck
Additionally this pulls in the following new transitive dependencies: - github.com/tklauser/go-sysconf - github.com/tklauser/numcpus
Additionally, it bumps the following dependencies - [github.com/BurntSushi/toml v0.3.1...v0.4.1](BurntSushi/toml@v0.3.1...v0.4.1) - [golang.org/x/mod v0.4.2...v0.5.1](golang/mod@v0.4.2...v0.5.1) - [golang.org/x/sys 69cdffdb9359...a2f17f7b995](golang/sys@69cdffd...a2f17f7) - [golang.org/x/tools v0.1.5...v0.1.7](golang/tools@v0.1.5...v0.1.7)
Merge branch 'master' of github.com:cockroachdb/vendored into pubsubSink
40d39da5 db: produce the FlushEnd event after installing readState cef3f146 compaction: add support for concurrent manual compactions cb848478 manifest: add methods for extending table bounds 7e5c8ee1 sstable: move block property collector calls to the Writer client goroutine 0e0d279a internal/keyspan: move MergingIter from internal/rangekey 09203fd9 *: Expose range key iterators through table cache 894b57aa db: correctly set point key bounds in `TestIngest_UpdateSequenceNumber` 6c7f6ed4 base: update IsExclusiveSentinel to account for multiple range key kinds e0589417 db: add external sstable merging iterator 85162b61 sstable: unify sstable size estimation by using a single abstraction bac6da8f internal/rangekey: adjust MergingIter interface, return fragment sets 7eb64ae7 Revert "db: add experimental DB.RegisterFlushCompletedCallback" 2c522458 db: remove unnecessary key clones during ingest load 998400e7 db: fix skipped key during Prev at synthetic range key marker 13f8f7ce *: separately track smallest/largest point/range keys in FileMetadata 7449c652 sstable: change index block size estimation to use inflight size 31899eb1 sstable: flush index blocks only from the Writer client goroutine 129bc0d4 internal/rangekey: fix invariant violation during SeekGE(upper-bound) 87ab6c71 db: write range keys to memtables
69a82fe4 sstable: circumvent a dataBlockBuf race in the sstable Writer d11e5f36 compaction: change `conflictsWithInProgress` to check keyranges 3f8713d3 tool/logs: various improvements to compaction event parser bdf07cc3 db: add iterator stats for iterators below the top-level db4b6dca sstable: fix race in sstable when parallelism is enabled
e2b7bb84 db: clear range key count during Batch Reset 9d0c3914 db: use L0 target file size, grandparent limit for intra L0 compactions e6b9afd6 sstable: fix bug with overall bound setting dc74f53e internal/manifest: refactor TestCheckOrdering to use ParseVersionDebug 02363a55 tool/logs: add ingested events, reorganize output e0cf288f tool/logs: fix single memtable flushes cd3d4bd4 ci: mark and close stale issues b4f1f653 base: fix InternalIteratorStats.Merge e7ea208e db: remove obsolete pickIntraL0 function 3515304a db: fix flaky TestOpenWALReplayReadOnlySeqNums
93d47226 db: add migration to rewrite atomic compaction units 6cebaf52 sstable: refactors WriterMetadata slice ownership 894918ec db: determine if memtable was flushed during ingestion test fcae8e49 sstable: document and confirm ownership invariants in the Writer 26d39952 internal/manifest: consolidate string printing methods 32fc56f9 internal/manifest: add file metadata debug string and parser 9021cc71 internal/manifest: remove (*Version).Pretty in favor of DebugString 5991b67d internal/manifest: format bounds consistently
6164579c cache: use finalizer for freeing manually allocated memory 0ad18689 compaction: disentangle compaction rangedels from InternalIterator 2c7b5358 ci: build and test against Go version 1.18 02418522 internal/metamorphic: add range key iteration 70ff2a37 internal/rangekey: seek exhausted iters when switching directions 7a946186 db: avoid levelIter invariant violation on exhausted mergingIter 10191d70 db: move range keys from memtable to global arena atomically a7cff657 db: fix determinism of limited reverse iteration with range keys 4ad1b577 *: Skip over files with no point keys in point key levelIter e19101fb sstable: re-pool datablock buffers in the sstable Writer f9d4a33d docs: minor tweaks to table format version RFC 910ce605 sstable: use a single level index in block property data driven test 56c5aebe internal/manifest: encode/decode range keys in manifest 11305409 internal/rangekey: refactor Coalescer into a pure function Coalesce fb5fdde8 db: fix TestSplitUserKeyMigration flake 9f45cc9a db: mock event duration directly in tests b1410e80 internal/lint: add a lint check to enforce crlfmt 9d3e2fc9 *: apply crlfmt 4dc50ecd internal/manifest: additional range key test cases for order checks
b33d6e17 internal/keyspan: remove bounds from FragmentIterator 07e7075b internal/keyspan: fix SeekLT bug 4c199d34 sstable: add scaffolding to enable sstable parallelism 338611b0 sstable: fix indexBlockBuf.shouldFlush by accounting for inflight data 8decd08c db: pool range-key iterator structs, remove Clone d8ca1fc6 keyspan: implement Truncate in terms of Filter 5926e724 keyspan: add `keyspan.Filter` 7582b880 db,record: add internal metrics for throughput, latency and utilization 8b3db52b internal/keyspan: Emit empty spans where there are no range keys 4a0889f8 db: add IngestOperationStats for admission control 194770c8 internal/metamorphic/crossversion: add TestMetaCrossVersion 785bb36d internal/keyspan: clean up InterleavingIter b9bcae65 db: generate delete compaction hints automatically in tests 4e77c077 db: update comment on L0StopWritesThreshold 99d8a549 internal/metamorphic: add support for an initial database state e232404f vfs: add CloneSync, CloneSkip options for vfs.Clone 7accf3df internal/metamorphic: use a wal_dir within the data directory 886e91f6 internal/keyspan: tweak DefragmentReducer return types 31def7d7 db: add additional deletion only hint test case; update diagram 1793e521 sstable: enforce sstable size estimation invariants e4927968 db: implement rangedel defragmentation using keyspan.DefragmentingIter 41895ae0 internal/keyspan: reduce over defragmented spans c55c1d80 db: check ordering invariant for sublevel compactions 322f7e9c internal/keyspan: genercize masking cca64783 compaction: add L0CompactionFileThreshold compaction trigger 5cd60640 db: respect changed filters in SetOptions 8cc87859 db: add additional table cache test for the Open function c8e7d414 db: add range key count to table stats ec4dcaa7 db: factor out some table stats helpers fb7ccaa2 internal/arenaskl: Overflow fixes 53fd136b internal/keyspan: move and refactor range key iterators as FragmentIterators c6ff6904 db: use sublevels for l0 manual compactions 8e8ff2be db: add Iterator.SetOptions for modifying iterator options 1b227d2c db: factor out point iterator initialization 3e86958e docs/rfc: flushable ingested sstable addition 0b5f42a0 internal/keyspan: Add LevelIter for range keys d7fb4eb2 docs/rfc: flushable ingested sstable 92c22536 db: remove unused variable from loop 7ad3551b *: refactor keyspan.Span to represent a set of keys
e567fec8 db: ensure Open closes opened directories on error b8c9a560 internal/metamorphic: overwrite unused bounds buffers 7c5f0cbb db: copy user-provided bounds and optimize unchanged bounds f8897076 *: Add IterOption to optionally read L6 filter blocks. d79f9617 vfs: extend disk-health checking to filesystem metadata operations 5ae21746 db: remove newRangeKeyIter closure 6d975489 db: add BenchmarkIteratorScan 782d102e sstable: fix invariant check for sstable size estimation 738a7f0b db: fix NewIter regression resulting in extra memtable levels 37558663 *: Use keyspan.LevelIter for rangedels in compactions e6c60c71 db: use sublevel level iters for all compactions out of L0 d8f63bef db: extend documentation on ingested file overlap; improve test cases b9e970a8 internal/keyspan: correct and document MergingIter key stability 498177bb internal/keyspan: collapse fragmentBoundIterator into MergingIter
bb2c1501 tool/logs: print total flush / ingestion counts and durations
d1cf3412 tool/logs: sort output by (start, node, store)
0a77780a tool/logs: fix total time calculation
0011c057 db: fix data race in SeekPrefixGE
99f35c80 internal/keyspan: gate invariant checks behind build tag
00302bfc internal/keyspan: use pointer receiver for most Span methods
3355a02e internal/rangekey: reduce range-key iteration allocations
4e33626f db: fix bug in interaction between Clone and indexed batches
b14ad704 metamorphic: enable writer parallelism for randomzied metamorphic runs
9bd43143 db: reduce allocations in range key iteration
e32e94d8 db: standardize behavior of indexed batch mutations during iteration
a07efd96 internal/keyspan: lift visibility filtering out of Seek{GE,LE}
|
I guess nobody's done a PR against this repo in a bit 😅 |
|
Indeed, we don't typically use PRs in this repo; https://github.com/cockroachdb/cockroach/blob/master/build/README.md#dependencies has some more details. |
|
I read through that document and it didn't seem like it'd be a problem to do a PR, just that we didn't normally do it. Is there a reason not to merge this PR? |
|
You can but merging a PR here doesn't really do anything; it just changes the We generally just advance the |
|
Commenting uninvited - but if you want a recorded discussion, perhaps before you add a lot of files to the repo, I think a PR in this repo is a fine way to do it. I think I've done it in the past. |
|
Oh I understand that it doesn't do anything, I just don't want to have to worry about my commit being on a separate branch that could be deleted by accident. I can push my branch directly to the repo if that'd be preferable! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades lib/pq to v1.10.6.