Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specification on NET Framework on slot for a webapp #74

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

nkuzmincodat
Copy link

@nkuzmincodat nkuzmincodat commented Mar 19, 2024

This PR closes #

The changes in this PR are as follows:

  • Allows specification of NET Framework for a web app slot
  • Adds .NET 8 member to Runtime

I have read the contributing guidelines and have completed the following:

  • Tested my code end-to-end against a live Azure subscription.
  • Updated the documentation in the docs folder for the affected changes.
  • Written unit tests against the modified code that I have made.
  • Updated the release notes with a new entry for this PR.
  • Checked the coding standards outlined in the contributions guide and ensured my code adheres to them.

If I haven't completed any of the tasks above, I include the reasons why here:

Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure:

let slot =
  appSlot {
      name "warm-up"
      runtime Runtime.DotNet80
  }

@nkuzmincodat nkuzmincodat self-assigned this Mar 19, 2024
src/Farmer/Builders/Builders.WebApp.fs Outdated Show resolved Hide resolved
src/Farmer/Builders/Builders.WebApp.fs Outdated Show resolved Hide resolved
src/Farmer/Builders/Builders.WebApp.fs Outdated Show resolved Hide resolved
src/Tests/WebApp.fs Outdated Show resolved Hide resolved
@nkuzmincodat nkuzmincodat requested a review from r30e March 19, 2024 13:26
@@ -137,6 +139,11 @@ type SlotConfig =
ApplyIPSecurityRestrictionsToScm = this.ApplyIPSecurityRestrictionsToScm
EnablePublicNetworkAccess = this.EnablePublicNetworkAccess
ZipDeployPath = None
NetFrameworkVersion = this.Runtime |> Option.map (fun r -> r |> function
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The joy of currying means you don't need to declare the lambda here, you can just use function directly which has a "dangling" second argument which is left to Option.map to fill in.

Suggested change
NetFrameworkVersion = this.Runtime |> Option.map (fun r -> r |> function
NetFrameworkVersion = this.Runtime |> Option.map (function

@nkuzmincodat nkuzmincodat merged commit c09c4f3 into master Mar 19, 2024
1 check passed
@JustinWilkinson JustinWilkinson deleted the add-runtime-to-slot branch March 20, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants