Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

++i is more gas efficient than i++ for loops. #6

Open
code423n4 opened this issue Oct 10, 2021 · 2 comments
Open

++i is more gas efficient than i++ for loops. #6

code423n4 opened this issue Oct 10, 2021 · 2 comments
Assignees
Labels
bug Warden finding G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

pants

Vulnerability details

At all loops definitions, you used i++ instead ++i although ++i is more gas efficient.
An even better approach is to use unchecked {++i}, since you are using solidity version >=0.8.

@PierrickGT
Copy link
Member

I did some gas golfing to figure out if ++i is really less gas consuming than i++. We would only save 5 gas per iteration but also lose in code clarity, so this gas saving trade off isn't really worth it.

About the unchecked part, results are a bit more convincing but still negligible. We would save 77 gas per iteration but as stated in the following issue, it is not possible to write unchecked { ++i } inline so we would have to write a helper function which would make our code less legible and harder to maintain in the future.

ethereum/solidity#10695

I've acknowledged the issue but we won't actually make the changes cause we prefer to keep a simple code base that will be easier to maintain in the future.

@PierrickGT PierrickGT added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Oct 13, 2021
@PierrickGT PierrickGT self-assigned this Oct 13, 2021
@GalloDaSballo
Copy link
Collaborator

The sponsor does acknowledge and I agree that the gas savings do not justify for the loss of clarity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Warden finding G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Development

No branches or pull requests

3 participants