Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of idea proposal EIP-677 #34

Closed
code423n4 opened this issue Apr 13, 2023 · 4 comments
Closed

Usage of idea proposal EIP-677 #34

code423n4 opened this issue Apr 13, 2023 · 4 comments
Labels
bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-b low quality report This report is of especially low quality QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2023-04-frankencoin/blob/f86279e76fd9f810d2a25243012e1be4191a547e/contracts/ERC20.sol#L161
https://github.com/code-423n4/2023-04-frankencoin/blob/f86279e76fd9f810d2a25243012e1be4191a547e/contracts/StablecoinBridge.sol#L75
https://github.com/code-423n4/2023-04-frankencoin/blob/f86279e76fd9f810d2a25243012e1be4191a547e/contracts/Equity.sol#L241

Vulnerability details

Impact

According to https://eips.ethereum.org/erc, the ERC-677 standard used in the project is not included in the Final, Last Call list of standards (This standard is an Idea and not a standard), which leads to the fact that a standard is used which has not been approved/deprecated or removed

Consequences:

  • this is not a standard
  • it can change
  • there are no clear requirements
  • truncated functionality as transferFromAndCall

Proof of Concept

Links to the code:

Tools Used

  • Manual review

Recommended Mitigation Steps
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Apr 13, 2023
code423n4 added a commit that referenced this issue Apr 13, 2023
@code423n4
Haipls issue #34
5ce5cc1
@c4-pre-sort
Copy link

0xA5DF marked the issue as low quality report

@c4-pre-sort c4-pre-sort added the low quality report This report is of especially low quality label Apr 22, 2023
@0xA5DF
Copy link

0xA5DF commented Apr 22, 2023

Might be a QA, no significant impact is demonstrated

@c4-judge c4-judge added downgraded by judge Judge downgraded the risk level of this issue QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax and removed 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value labels May 11, 2023
@c4-judge
Copy link
Contributor

hansfriese changed the severity to QA (Quality Assurance)

@c4-judge
Copy link
Contributor

hansfriese marked the issue as grade-b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-b low quality report This report is of especially low quality QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@code423n4 @0xA5DF @c4-judge @c4-pre-sort @C4-Staff