Root delay can be more than 4 weeks

[c4-submissions]

Lines of code

https://github.com/code-423n4/2023-09-centrifuge/blob/512e7a71ebd9ae76384f837204216f26380c9f91/src/Root.sol#L36

Vulnerability details

Impact

Delay can be set to more than 4 weeks in root.sol

Proof of Concept

When deploying root.sol, delay can be set to more than 4 weeks by mistake

 constructor(address _escrow, uint256 _delay) {
        escrow = _escrow;
        delay = _delay;

        wards[msg.sender] = 1;
        emit Rely(msg.sender);
    }

Tools Used

Manual review

Recommended Mitigation Steps

check if delay is less than weeks in constructor,

 constructor(address _escrow, uint256 _delay) {
        escrow = _escrow;
        require(_delay <  4 weeks,"error")
        delay = _delay;

        wards[msg.sender] = 1;
        emit Rely(msg.sender);
    }

Assessed type

Invalid Validation

[c4-pre-sort]

raymondfam marked the issue as low quality report

[c4-pre-sort]

raymondfam marked the issue as duplicate of #298

[c4-judge]

gzeon-c4 changed the severity to QA (Quality Assurance)