Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #82

Open
c4-bot-10 opened this issue Feb 27, 2024 · 4 comments
Open

QA Report #82

c4-bot-10 opened this issue Feb 27, 2024 · 4 comments
Labels
bug Something isn't working grade-b high quality report This report is of especially high quality Q-12 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@c4-bot-10
Copy link
Contributor

See the markdown file with the details of this report here.
@c4-bot-10 c4-bot-10 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Feb 27, 2024
c4-bot-5 added a commit that referenced this issue Feb 27, 2024
@c4-bot-5
Franfran issue #82
d33842c
c4-bot-10 added a commit that referenced this issue Feb 27, 2024
@c4-bot-10
Franfran data for issue #82
f1fcd1c
@c4-pre-sort
Copy link

0xRobocop marked the issue as high quality report

@c4-pre-sort c4-pre-sort added the high quality report This report is of especially high quality label Mar 3, 2024
@c4-sponsor
Copy link

enthusiastmartin (sponsor) disputed

@c4-sponsor c4-sponsor added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Mar 6, 2024
@enthusiastmartin
Copy link

This report have most of the things wrong.

Low1 - invalid - it does not need to round up if decimals < target decimals.
it is simple multiplication.

Low2 - invalid - we need to see the places where the rounding is incorrect.

low3 - invalid - it does not work like that in polkadot

Low4 - not in scope, substrate dependencies

Info 1,2,3,4 - not really issues, untested report might be incorrect due to tool used which does not capture things correctly.

@c4-judge
Copy link

c4-judge commented Mar 8, 2024

OpenCoreCH marked the issue as grade-b

@C4-Staff C4-Staff added the Q-12 label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working grade-b high quality report This report is of especially high quality Q-12 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@enthusiastmartin @c4-judge @c4-sponsor @c4-pre-sort @C4-Staff @c4-bot-10