Skip to content

Commit

Permalink
[Fiber] Log Effect and Render Times in Offscreen Commit Phase (facebo…
Browse files Browse the repository at this point in the history
…ok#31788)

In facebook#30967 and
facebook#30983 I added logging of the just
rendered components and the effects. However this didn't consider the
special Offscreen passes. So this adds the same thing to those passes.

Log component effect timings for disconnected/reconnected offscreen
subtrees. This includes initial mount of a Suspense boundary.

Log component render timings for reconnected and already offscreen
offscreen subtrees.

DiffTrain build for [6a4b46c](facebook@6a4b46c)
  • Loading branch information
pull[bot] committed Dec 18, 2024
1 parent 21e5027 commit dcc30de
Show file tree
Hide file tree
Showing 34 changed files with 920 additions and 920 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
facec3ee71fff8b23f1e91005fce730cc96e4021
6a4b46cd70d2672bc4be59dcb5b8dede22ed0cef
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION_TRANSFORMS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
facec3ee71fff8b23f1e91005fce730cc96e4021
6a4b46cd70d2672bc4be59dcb5b8dede22ed0cef
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -1942,7 +1942,7 @@ __DEV__ &&
exports.useTransition = function () {
return resolveDispatcher().useTransition();
};
exports.version = "19.1.0-www-classic-facec3ee-20241217";
exports.version = "19.1.0-www-classic-6a4b46cd-20241217";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -1942,7 +1942,7 @@ __DEV__ &&
exports.useTransition = function () {
return resolveDispatcher().useTransition();
};
exports.version = "19.1.0-www-modern-facec3ee-20241217";
exports.version = "19.1.0-www-modern-6a4b46cd-20241217";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -630,4 +630,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.1.0-www-classic-facec3ee-20241217";
exports.version = "19.1.0-www-classic-6a4b46cd-20241217";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -630,4 +630,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.1.0-www-modern-facec3ee-20241217";
exports.version = "19.1.0-www-modern-6a4b46cd-20241217";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.1.0-www-classic-facec3ee-20241217";
exports.version = "19.1.0-www-classic-6a4b46cd-20241217";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.1.0-www-modern-facec3ee-20241217";
exports.version = "19.1.0-www-modern-6a4b46cd-20241217";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -13847,7 +13847,7 @@ __DEV__ &&
shouldDoubleInvokePassiveEffects && disconnectPassiveEffect(fiber),
reappearLayoutEffects(root, fiber.alternate, fiber, !1),
shouldDoubleInvokePassiveEffects &&
reconnectPassiveEffects(root, fiber, 0, null, !1);
reconnectPassiveEffects(root, fiber, 0, null, !1, 0);
} finally {
setIsStrictModeForDevtools(!1);
}
Expand Down Expand Up @@ -16898,10 +16898,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.1.0-www-classic-facec3ee-20241217",
version: "19.1.0-www-classic-6a4b46cd-20241217",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-classic-facec3ee-20241217"
reconcilerVersion: "19.1.0-www-classic-6a4b46cd-20241217"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -16935,7 +16935,7 @@ __DEV__ &&
exports.Shape = Shape;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.1.0-www-classic-facec3ee-20241217";
exports.version = "19.1.0-www-classic-6a4b46cd-20241217";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
8 changes: 4 additions & 4 deletions compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -13647,7 +13647,7 @@ __DEV__ &&
shouldDoubleInvokePassiveEffects && disconnectPassiveEffect(fiber),
reappearLayoutEffects(root, fiber.alternate, fiber, !1),
shouldDoubleInvokePassiveEffects &&
reconnectPassiveEffects(root, fiber, 0, null, !1);
reconnectPassiveEffects(root, fiber, 0, null, !1, 0);
} finally {
setIsStrictModeForDevtools(!1);
}
Expand Down Expand Up @@ -16661,10 +16661,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.1.0-www-modern-facec3ee-20241217",
version: "19.1.0-www-modern-6a4b46cd-20241217",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-modern-facec3ee-20241217"
reconcilerVersion: "19.1.0-www-modern-6a4b46cd-20241217"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -16698,7 +16698,7 @@ __DEV__ &&
exports.Shape = Shape;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.1.0-www-modern-facec3ee-20241217";
exports.version = "19.1.0-www-modern-6a4b46cd-20241217";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
20 changes: 10 additions & 10 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -10755,24 +10755,24 @@ var slice = Array.prototype.slice,
};
return Text;
})(React.Component);
var internals$jscomp$inline_1493 = {
var internals$jscomp$inline_1495 = {
bundleType: 0,
version: "19.1.0-www-classic-facec3ee-20241217",
version: "19.1.0-www-classic-6a4b46cd-20241217",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-classic-facec3ee-20241217"
reconcilerVersion: "19.1.0-www-classic-6a4b46cd-20241217"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1494 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
var hook$jscomp$inline_1496 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
if (
!hook$jscomp$inline_1494.isDisabled &&
hook$jscomp$inline_1494.supportsFiber
!hook$jscomp$inline_1496.isDisabled &&
hook$jscomp$inline_1496.supportsFiber
)
try {
(rendererID = hook$jscomp$inline_1494.inject(
internals$jscomp$inline_1493
(rendererID = hook$jscomp$inline_1496.inject(
internals$jscomp$inline_1495
)),
(injectedHook = hook$jscomp$inline_1494);
(injectedHook = hook$jscomp$inline_1496);
} catch (err) {}
}
var Path = Mode$1.Path;
Expand All @@ -10786,4 +10786,4 @@ exports.RadialGradient = RadialGradient;
exports.Shape = TYPES.SHAPE;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.1.0-www-classic-facec3ee-20241217";
exports.version = "19.1.0-www-classic-6a4b46cd-20241217";
20 changes: 10 additions & 10 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -10471,24 +10471,24 @@ var slice = Array.prototype.slice,
};
return Text;
})(React.Component);
var internals$jscomp$inline_1472 = {
var internals$jscomp$inline_1474 = {
bundleType: 0,
version: "19.1.0-www-modern-facec3ee-20241217",
version: "19.1.0-www-modern-6a4b46cd-20241217",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-modern-facec3ee-20241217"
reconcilerVersion: "19.1.0-www-modern-6a4b46cd-20241217"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1473 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
var hook$jscomp$inline_1475 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
if (
!hook$jscomp$inline_1473.isDisabled &&
hook$jscomp$inline_1473.supportsFiber
!hook$jscomp$inline_1475.isDisabled &&
hook$jscomp$inline_1475.supportsFiber
)
try {
(rendererID = hook$jscomp$inline_1473.inject(
internals$jscomp$inline_1472
(rendererID = hook$jscomp$inline_1475.inject(
internals$jscomp$inline_1474
)),
(injectedHook = hook$jscomp$inline_1473);
(injectedHook = hook$jscomp$inline_1475);
} catch (err) {}
}
var Path = Mode$1.Path;
Expand All @@ -10502,4 +10502,4 @@ exports.RadialGradient = RadialGradient;
exports.Shape = TYPES.SHAPE;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.1.0-www-modern-facec3ee-20241217";
exports.version = "19.1.0-www-modern-6a4b46cd-20241217";
Loading

0 comments on commit dcc30de

Please sign in to comment.