-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bookmark and view of bookmark #1232
Conversation
contentId={contentId} | ||
/> | ||
); | ||
} else if (type === 'folder' && !parent) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this else sir? from what i can see you are returning the same thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
videoUrl is diff in both the case. there was already an implementation for type == 'video'. I do not want to break that. plus control will not go inside if in case of folder because parent will be null.
@siinghd let me know if you feel some changes is required. also, rn in production user can create same bookmark multiple time. creating multiple entry of same contentId. I think we should change the schema of bookmark to
here is a script to delete multiple records then we can do prisma migrate.
|
thankss |
PR Fixes:
Resolves #1231
Screencast from 15-09-24 09:52:22 PM IST.webm
Checklist before requesting a review