Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/1245-Keyboard Shortcut Guide Implemented #1246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pkmanas22
Copy link
Contributor

PR Fixes:

Resolves #1245

  • Implemented a pop-up window to display keyboard shortcuts for the video player.
  • Navigation links to important sections of the application were included.

My changes are inside src/app/layout.tsx and src/components/helpSection/

Some Screenshots

image
image
image

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@pkmanas22
Copy link
Contributor Author

@hkirat @devsargam sir, please review this code

@pkmanas22
Copy link
Contributor Author

Is there any problem/ error sir @hkirat @devsargam

@devsargam
Copy link
Collaborator

There's no problem but don't see much point here still will merge tom just closing all issues @pkmanas22

@pkmanas22
Copy link
Contributor Author

There's no problem but don't see much point here still will merge tom just closing all issues @pkmanas22

I also implemented same feature before, and unfortunately the code is outdated, so I do revised one, thank you for looking into it @devsargam bro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: There should be Keyboard Shortcut Guide
2 participants