Chore/dataframe formatter handle nulls #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
3 tasks
antazoey
reviewed
Feb 16, 2021
maddie-vargo
added a commit
to maddie-vargo/code42cli
that referenced
this pull request
Feb 16, 2021
antazoey
reviewed
Feb 17, 2021
| ) | ||
| def get_formatted_output(self, df, **kwargs): | ||
| if self.output_format == OutputFormat.JSON: | ||
| defaults = { |
There was a problem hiding this comment.
could use a helper method _get_json_defaults(lines=True) to share this part with the .RAW part
alanag13
reviewed
Feb 17, 2021
alanag13
reviewed
Feb 17, 2021
alanag13
approved these changes
Feb 17, 2021
antazoey
approved these changes
Feb 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our DataFrameOutputFormatter to automatically convert "null" values in the dataframe (
None,numpy.NaN) to empty strings when outputting to table or CSV. For json output pandas automatically converts these to a jsonnull.I refactored it a bit to hopefully be a little clearer, and updated the tests to validate the expected result instead of a specific implementation detail.