Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NPM to fix vulnerability issue #119

Merged
merged 13 commits into from
Jul 20, 2020
Merged

Update NPM to fix vulnerability issue #119

merged 13 commits into from
Jul 20, 2020

Conversation

angelocordon
Copy link
Contributor

@angelocordon angelocordon commented Jul 19, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Update NPM packages to handle build failing issues.

@lpatmo
Copy link
Member

lpatmo commented Jul 19, 2020

I have the latest checkout of the npm-test-fix branch, and am confused why tests are passing locally:

image

One of the errors from https://github.com/codebuddies/frontend/runs/886181183?check_suite_focus=true seems to be related to testing-library/dom-testing-library#477, which I remember we handled by adding a SKIP_PREFLIGHT_CHECK=true to .env.

@lpatmo lpatmo merged commit 326f12f into main Jul 20, 2020
@angelocordon angelocordon deleted the npm-test-fix branch September 12, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants