Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance update on GenerateQrCode function #438

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Performance update on GenerateQrCode function #438

merged 4 commits into from
Apr 19, 2024

Conversation

HolyOne
Copy link
Contributor

@HolyOne HolyOne commented Dec 24, 2022

Faster generation of QRCode using StringBuilder

gfoidl
gfoidl reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@gfoidl gfoidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The StringBuilder could be used in GenerateQrCode as well, to avoid the string-manipulations (and these allocations).

QRCoder/QRCodeGenerator.cs Outdated Show resolved Hide resolved
QRCoder/QRCodeGenerator.cs Outdated Show resolved Hide resolved
QRCoder/QRCodeGenerator.cs Outdated Show resolved Hide resolved
@Shane32 Shane32 mentioned this pull request Apr 2, 2024
Merged
codebude and others added 3 commits April 19, 2024 22:30
@codebude @gfoidl
Update QRCoder/QRCodeGenerator.cs
c85200c 
Co-authored-by: Günther Foidl <gue@korporal.at>
@codebude @gfoidl
Update QRCoder/QRCodeGenerator.cs
b9dad0a 
Co-authored-by: Günther Foidl <gue@korporal.at>
@codebude @gfoidl
Update QRCoder/QRCodeGenerator.cs
62e32a9 
Co-authored-by: Günther Foidl <gue@korporal.at>
@codebude codebude merged commit ee3a6e7 into codebude:master Apr 19, 2024
1 check passed
@codebude
Copy link
Owner

Hi @HolyOne , hi @gfoidl Thanks for your support and pointing me onto this topic. I just re-fined your PR a little bit. I think by setting the capacity we can squeeze out even a little bit more performance. 0c54783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfoidl gfoidl gfoidl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HolyOne @codebude @gfoidl