Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple end points #231

Closed
wants to merge 1 commit into from
Closed

Multiple end points #231

wants to merge 1 commit into from

Conversation

mikexliu
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 88.388% when pulling cf75799 on mikexliu:multiple_end_points into 918201c on codecentric:master.

@mikexliu
Copy link
Author

I couldn't think of a case where we would only want to register against exactly one admin-server if there are multiple available. My use case is we have a centralized admin-server but each service also is hosting its own admin-server. I would like to have the data be pushed to both endpoints.

If the centralized admin-server goes down, it's still accessible via the service itself (or if you have multiple dedicated admin-servers, then they would have the data immediately as opposed to having to wait for the next registration).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 88.388% when pulling 793d0ff on mikexliu:multiple_end_points into 918201c on codecentric:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 88.388% when pulling 793d0ff on mikexliu:multiple_end_points into 918201c on codecentric:master.

@joshiste
Copy link
Collaborator

joshiste commented Jul 15, 2016

First of all thank you for the PR.

In my opinion an option spring.boot.admin.register-once with default true for the old behaviour would be good. And I would appreciate if you would sqash all commits into a single one and do a forced push to your branch.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 88.382% when pulling 68d34d1 on mikexliu:multiple_end_points into 918201c on codecentric:master.

@mikexliu
Copy link
Author

@joshiste
Thanks. I've squashed it into one commit. The only issue I still have is the return value of register. If you are registering against multiple and some fail, should it still be false or should it be true? Current implementation is true if even one is successful.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 88.382% when pulling 68d34d1 on mikexliu:multiple_end_points into 918201c on codecentric:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 88.382% when pulling 68d34d1 on mikexliu:multiple_end_points into 918201c on codecentric:master.

@joshiste
Copy link
Collaborator

merged with b0330cd

@joshiste joshiste closed this Jul 15, 2016
@joshiste joshiste added this to the 1.3.5 milestone Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants