Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add deep deps #424

Merged
merged 7 commits into from
Jul 19, 2021
Merged

fix: Add deep deps #424

merged 7 commits into from
Jul 19, 2021

Conversation

thomasrockhu
Copy link
Contributor

@thomasrockhu thomasrockhu commented Jul 19, 2021

Adding a dist/node_modules folder due to issues with openpgp. This will likely be resolved when they release 5.0.0. It's not the most elegant way, but it works for now. See vercel/ncc#538

Fixes #423

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #424 (852cffb) into master (d4d413d) will increase coverage by 0.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   96.52%   97.34%   +0.82%     
==========================================
  Files           3        3              
  Lines         115      113       -2     
  Branches       34       34              
==========================================
- Hits          111      110       -1     
+ Misses          4        3       -1     
Flag Coverage Δ
demo 85.71% <ø> (-1.79%) ⬇️
macos-latest 97.34% <ø> (+0.82%) ⬆️
script 98.98% <ø> (+1.01%) ⬆️
ubuntu-latest 97.34% <ø> (+0.82%) ⬆️
windows-latest 97.34% <ø> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
demo/coverage-test/coverage.ts 77.77% <0.00%> (-2.23%) ⬇️
demo/calculator/calculator.ts 100.00% <0.00%> (ø)
src/buildExec.ts 98.98% <0.00%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d413d...852cffb. Read the comment docs.

@thomasrockhu thomasrockhu force-pushed the 2.0.1-fix-deps branch 3 times, most recently from d7a0e59 to d5b33d5 Compare July 19, 2021 15:43
@thomasrockhu thomasrockhu requested a review from a team July 19, 2021 15:46
Copy link
Contributor

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a lot of files in ere that I don't think are needed, but lets get it working first. 👍

@thomasrockhu thomasrockhu merged commit c585afe into master Jul 19, 2021
@thomasrockhu thomasrockhu deleted the 2.0.1-fix-deps branch July 19, 2021 16:05
@RA80533
Copy link
Contributor

RA80533 commented Jul 20, 2021

I'm going to follow up on this and investigate why this issue is occurring. I suspected it was due to asn1.js being declared as the wrong type of dependency—peerDependencies were treated as "optional" for npm versions prior to v7—but this does not appear to be the case (based on the issue linked).

With regards to tracking node_modules in the repository, the GitHub Actions documentation recommends doing so for most Node.js projects that run on the platform. At the very least, the practice is not without merit.

@RA80533 RA80533 mentioned this pull request Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 is not working, cannot find module 'asn1.js'
3 participants