Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add network prefix and filter options #406

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Apr 5, 2024

fixes #405

This adds the --network-prefix and --network-filter arguments that existed in the uploader (and the bash uploader).

This PR does the following:

  • Alphabetizes some of the arguments
  • Adds the --network-prefix and --network-filter arguments
  • Pass those arguments down to NetworkFinder.find_files and execute on them
  • Pass in the --network-root-folder to the NetworkFinder.find_files function also
  • Change _produce_file_fixes_for_network to _produce_file_fixes as file fixes are not relevant to the network. This helps prevent file fixes from blowing up since the network filepaths are changing

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.06%. Comparing base (3ce68bd) to head (976a2d1).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   95.76%   96.06%   +0.29%     
==========================================
  Files          81       81              
  Lines        2925     2843      -82     
==========================================
- Hits         2801     2731      -70     
+ Misses        124      112      -12     
Flag Coverage Δ
python3.10 96.34% <100.00%> (+0.01%) ⬆️
python3.11 96.34% <100.00%> (+0.01%) ⬆️
python3.8 96.31% <100.00%> (+0.01%) ⬆️
python3.9 96.31% <100.00%> (+0.01%) ⬆️
smart-labels 96.05% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

codecov_cli/commands/upload.py Show resolved Hide resolved
codecov_cli/commands/upload.py Outdated Show resolved Hide resolved
codecov_cli/services/upload/upload_collector.py Outdated Show resolved Hide resolved
@thomasrockhu-codecov
Copy link
Contributor Author

Updated PTAL @joseph-sentry

@thomasrockhu-codecov thomasrockhu-codecov merged commit 750e957 into main Apr 8, 2024
18 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the th/network-prefix-and-filter branch April 8, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port over network filter and prefix
3 participants