-
Notifications
You must be signed in to change notification settings - Fork 21
Report uploads fails on certain branches and/or job IDs #36
Comments
this will be fixed in the upcoming release of the next version |
@Sharparam are you able to verify that this was indeed fixed in the latest release of codecov exe? (Version 1.0.4). |
@AdmiringWorm Hm, it seems to be failing still: https://ci.appveyor.com/project/Corale/colore/build/138 |
@AdmiringWorm I added URL escaping to the version number as well and that seems to make it work: https://ci.appveyor.com/project/Corale/colore/build/6.0.0-upgrade-codecov.1+234.build.139 (This build also has verbose logging turned on for Codecov) |
hmm, I see that the build that succeeds that you linked to actually double encodes the How you got that though I have no idea, do you run a custom edition of codecov-exe? Anyways, something I have to take a closer look into. |
It seems to be encoding the percentage sign actually:
The string passed in by me to the Codecov tool (no custom build) is I don't see Codecov displaying this version number anywhere to verify what the final version it got was. |
ah, that would explain it why it was encoded. |
For the version string (placed in the |
@Sharparam I just made some changes to the library (not pushed to github yet), and uploaded a beta package to a personal myget repository. Could I ask you to test out that beta package before I make any release?
|
It seems like this is actually fixed now. I'm closing this one again, and preparing to release a new version of codecov-exe. |
I'm not at home yet so can't test. Should I leave it as it currently is
(escaping both branch and version string)?
…On Sun, 1 Jul 2018, 14:15 Kim J. Nordmo, ***@***.***> wrote:
It seems like this is actually fixed now.
I'm closing this one again, and preparing to release a new version of
codecov-exe.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAhotiCymnaTQBWU28Z1HtZuiL5si2PUks5uCL11gaJpZM4Uqv9F>
.
|
You could try both. I'll hold off with the release until later today. |
I decided to release the new version now (still being indexed on nuget.org though). Let me know if it still doesn't work. |
We are uploading coverage reports in our AppVeyor build (via Cake.Codecov) which works fine for the
develop
branch, but fails when it's building feature branches.Working AppVeyor build on
develop
branch: https://ci.appveyor.com/project/Corale/colore/build/6.0.0-unstable.231.build.137Broken AppVeyor build on
feature/upgrade-dotnet-sdk
branch: https://ci.appveyor.com/project/Corale/colore/build/6.0.0-upgrade-dotnet-sdk.1+230.build.136The only difference between the two is the branch and version being generated, the two CodeCov URLs are:
Working:
https://codecov.io/upload/v4?branch=develop&commit=c452ba71592bf81a23091bc070aae905da01fcd3&build=27iw4u2biyyj72k7&tag=&pr=&name=&flags=&slug=chroma-sdk%2FColore&token=&package=exe-1.0.3&build_url=&yaml=.codecov.yml&job=Corale%2Fcolore%2F6.0.0-unstable.231.build.137&service=appveyor
Broken:
https://codecov.io/upload/v4?branch=feature%2Fupgrade-dotnet-sdk&commit=33a280c35f7c9256b15495f517438acf617bcbc5&build=ses9x3442e84l6td&tag=&pr=&name=&flags=&slug=chroma-sdk%2FColore&token=&package=exe-1.0.3&build_url=&yaml=.codecov.yml&job=Corale%2Fcolore%2F6.0.0-upgrade-dotnet-sdk.1%2B230.build.136&service=appveyor
As you can see, the branch name is escaped properly, so this is not related to #32.
The only thing I can think of is that the Codecov service doesn't like the escaped '+' sign in the job ID (
%2B
)? Slashes (%2F
) appear to be fine as they are present in the working build as well.The text was updated successfully, but these errors were encountered: