Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Add suport for Azure Pipelines #51

Closed
wants to merge 2 commits into from
Closed

Add suport for Azure Pipelines #51

wants to merge 2 commits into from

Conversation

clairernovotny
Copy link
Contributor

@clairernovotny clairernovotny commented Feb 20, 2019 •
edited
Loading

Fixes #50

@AdmiringWorm
Copy link
Collaborator

Thank you for opening a PR to implement this. I do not have the possibility to review the PR at this time, but hope to manage to review it tomorrow (at the latest friday).

@AdmiringWorm AdmiringWorm self-requested a review February 20, 2019 17:41
@AdmiringWorm AdmiringWorm changed the base branch from master to develop February 20, 2019 17:42
@hootener hootener mentioned this pull request Feb 27, 2019
Closed
@astrofrog
Copy link

Looking forward to this!

AdmiringWorm
AdmiringWorm approved these changes Feb 28, 2019
View reviewed changes
Copy link
Collaborator

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution.
I apologise for the long delay of me review this PR.

I'm currently preparing a new release, in which this feature will be among them.

@AdmiringWorm
Copy link
Collaborator

Your changes have been merged into the develop branch here: cb77bae

@AraHaan
Copy link

AraHaan commented Apr 16, 2019 •
edited
Loading

Is this merged into master yet? my version that I am installing manually from nuget.org on appveyor and azure pipelines seems to have a issue identifying this exact thing and I was just about to open a new issue that would be a duplicate of #50. If there is a newer nuget.org release mind editing my Appveyor and azure yml’s to fix the issue in my repo?

https://github.com/AraHaan/XmlAbstraction/

Edit: It is because I am using v1.1.0 but the latest is v1.4.0 maybe you guys should warn people if and when the tool discovers a new version from the github releases?

sharwell added a commit to sharwell/roslyn-analyzers that referenced this pull request Nov 15, 2019
@sharwell
Remove unnecessary codecov args
b293b8b 
Azure Pipelines is now supported by the codecov uploader.

See codecov/codecov-exe#51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AdmiringWorm AdmiringWorm AdmiringWorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clairernovotny @AdmiringWorm @astrofrog @AraHaan