This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Recover broken find pattern for UNIX #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: codecov#184 continuous from: ada583b codecov#180 makes `find` command change to run through `execFileSync()`. However, it always returns empty result because of the quote has over-included as the filename of search condition. So removed quotes from generated conditions. In addition, removing brackets from find arguments (a4cc565) has affected to the result of finding coverage files. This commit reverts brackets to get back the original search condition too. Previously quotes and escaped-brackets are required to run command on the shell environment, but no longer need them because of using `execFileSync()` that is disabled shell environment by default.
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=========================================
Coverage ? 88.64%
=========================================
Files ? 23
Lines ? 370
Branches ? 91
=========================================
Hits ? 328
Misses ? 34
Partials ? 8
Continue to review full report at Codecov.
|
This was referenced Jul 21, 2020
|
Tests are being flaky, need to be mocked out in the future. I'm comfortable with this change. |
thomasrockhu
approved these changes
Jul 22, 2020
alexkli
added a commit
to adobe/asset-compute-sdk
that referenced
this pull request
Jul 22, 2020
alexkli
added a commit
to adobe/asset-compute-sdk
that referenced
this pull request
Jul 22, 2020
…tion dependency, fix codecov in build (#25) * fix codecov * update @adobe/cgroup-metrics to 3.0.1 * fix codecov missing the coverage data * update to latest codecov 3.7.2 as 3.7.1 was completely broken see codecov/codecov-node#185 * add codecov badge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#180 makes
findcommand change to run throughexecFileSync(). However, it always returns empty result because of the quote has over-included as the filename of search condition. So I removed quotes from conditions.In addition, removing brackets from find arguments (a4cc565) has affected to the result of finding coverage files. This commit reverts brackets to get back the original search condition too.
Previously quotes and escaped-brackets are required to run command on the shell environment by
execSync(), but no longer need them because of usingexecFileSync()that is disabled shell environment by default.Fix #184.