Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Validate UUID tokens #239

Merged
merged 1 commit into from
Jul 22, 2021
Merged

fix: Validate UUID tokens #239

merged 1 commit into from
Jul 22, 2021

Conversation

thomasrockhu
Copy link
Contributor

@thomasrockhu thomasrockhu requested a review from a team July 22, 2021 17:23
drazisil-codecov
drazisil-codecov approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasrockhu is my hero

@codecov
Copy link

codecov bot commented Jul 22, 2021 •
edited
Loading

Codecov Report

Merging #239 (1756b26) into master (b3d01c0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #239   +/-   ##
=======================================
  Coverage   94.69%   94.69%           
=======================================
  Files          23       23           
  Lines         810      810           
  Branches      145      146    +1     
=======================================
  Hits          767      767           
  Misses         12       12           
  Partials       31       31
Flag Coverage Δ
alpine 94.69% <100.00%> (ø)
linux 94.69% <100.00%> (ø)
linux-without-git 94.69% <100.00%> (ø)
macos 94.69% <100.00%> (ø)
macos-without-git 94.69% <100.00%> (ø)
windows 94.07% <100.00%> (ø)
windows-without-git 94.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helpers/validate.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d01c0...1756b26. Read the comment docs.

@thomasrockhu thomasrockhu merged commit 300eb11 into master Jul 22, 2021
@thomasrockhu thomasrockhu deleted the fix-uuid-token branch July 22, 2021 17:44
@thomasrockhu thomasrockhu mentioned this pull request Jul 22, 2021
Merged
@RA80533
Copy link
Contributor

RA80533 commented Jul 22, 2021

Closes #222
Closes #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-codecov michael-codecov michael-codecov approved these changes

@drazisil-codecov drazisil-codecov drazisil-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to properly upload, codecov failed with exit code 255
4 participants
@thomasrockhu @RA80533 @drazisil-codecov @michael-codecov