Add Heroku nodejs buildpack #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monfresh
force-pushed
the
mb-update-app-json
branch
from
b49ada9
to
db6c367
Compare
monfresh
force-pushed
the
mb-update-app-json
branch
from
db6c367
to
1b1ef51
Compare
**Why**: After upgrading to the latest webpacker, assets failed to compile on Heroku. This issue says you need to add the nodejs buildpack: rails/webpacker#739 Make sure the nodejs buildpack comes before the ruby one. For existing apps, this can be done like so: heroku buildpacks:add heroku/nodejs -i 1 -a your_app_name I also removed unnecessary items from app.json.
monfresh
force-pushed
the
mb-update-app-json
branch
from
1b1ef51
to
84d7d60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: After upgrading to the latest webpacker, assets failed to compile on Heroku. This issue says you need to add the nodejs buildpack: rails/webpacker#739
I also removed unnecessary items from app.json.