Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to system resolve if error file path not relative #1976

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

worksofliam
Copy link
Contributor

Changes

Fixes #1944, where if you had a member include from your local compile, it was not resolving in the Problems view correctly.

How to test this PR

  1. Run the test cases

Example file:

**free
// put this in YOURLIB/ASRCPF/AMBR.RPGLE
dcl-c MYNUMBER 27;
**free

# put this in your local workspace

/copy yourlib/asrcpf,ambr

dcl-s mytext char(1);

mytext = '1';

return;

After compiling the local workspace file, you should see the info message point to the member correctly.

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam worksofliam added the bug A confirmed issue when something isn't working as intended label Apr 5, 2024
@william-xiang
Copy link
Contributor

@sebjulliand Could you review this PR when you have time?
It works for me in both local vscode and merlin.

@eric-simpson
Copy link

@sebjulliand Seb, can you review this?

@worksofliam
Copy link
Contributor Author

@william-xiang If you have tested and are happy then I will accept your review.

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worksofliam @eric-simpson @william-xiang sorry, it was quite busy these days.
Anyway, I tested it, tried a few different kind of include paths and it works just fine.
I pushed a small cleanup commit.
@worksofliam feel free to merge whenever you want.

@worksofliam worksofliam merged commit cc8940a into master Apr 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnostics for include files From QSYS has the wrong path in problems view
4 participants