Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change where manage debug context is set #2048

Merged
merged 1 commit into from
May 10, 2024
Merged

Change where manage debug context is set #2048

merged 1 commit into from
May 10, 2024

Conversation

worksofliam
Copy link
Contributor

Changes

On the edge case when other extensions are setting the DEBUG_MANAGED variable, we now set the context when the connection is made.

How to test this PR

Examples:

  1. Set the environment variable DEBUG_MANAGED before connecting to a system and expect the debug setup view to be hidden.

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@worksofliam
Change where manage debug context is set
e26555d 
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
SanjulaGanepola
SanjulaGanepola approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@SanjulaGanepola SanjulaGanepola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Thanks for the fix

@worksofliam worksofliam merged commit c213ab3 into master May 10, 2024
1 check passed
@worksofliam worksofliam added this to the 2.11.0 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanjulaGanepola SanjulaGanepola SanjulaGanepola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@worksofliam @SanjulaGanepola