Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types generation #2080

Merged
merged 1 commit into from
May 31, 2024
Merged

Fix types generation #2080

merged 1 commit into from
May 31, 2024

Conversation

sebjulliand
Copy link
Collaborator

@sebjulliand sebjulliand commented May 28, 2024 •
edited
Loading

Changes

Adds the --resolveJsonModule flag to the command generating the types to fix this error:
image

How to test this PR

  1. Apply the PR
  2. Run npm run typings from a terminal
  3. Types must be generated

Checklist

  • have tested my change

@sebjulliand
Fix types generation
812143e 
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label May 28, 2024
@sebjulliand sebjulliand requested a review from a team May 28, 2024 13:04
@sebjulliand sebjulliand self-assigned this May 28, 2024
worksofliam
worksofliam approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. Sorry I didn't catch this before.

@worksofliam worksofliam merged commit 02bf027 into master May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worksofliam worksofliam worksofliam approved these changes

Assignees

@sebjulliand sebjulliand

Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebjulliand @worksofliam