Only show server ports in Debug Service tooltip #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
sebjulliand
added
the
bug
worksofliam
approved these changes
Jun 10, 2024
|
@sebjulliand Shall we merge? |
|
@worksofliam oof, I forgot about it 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In its current state, the
Debug Serviceitem tooltip in theIBM i Debuggerview shows too many ports:The ports besides 8001 and 8005 are those used by the Service when it connects to the local TCP servers; they only appear once the Debug Service has been used at least once to debug a program:
This PR fixes the query used to fetch the Service ports to only get the server ports.
How to test this PR
IBM i DebuggerviewDebug ServiceitemChecklist