Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always debug securely #2157

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Always debug securely #2157

merged 2 commits into from
Jul 10, 2024

Conversation

sebjulliand
Copy link
Collaborator

Changes

This PR removes the debugIsSecure parameter from the connection settings.
Since the Service Entry Points requires a client certificate, there is no point in keeping the option to turn off secure debugging.

If the client certificate is not found locally or if there is a mismatch, the IBM i Debugger view will offer to download and update it locally.

A notification is shown in the status bar when the client certificate is being downloaded.

How to test this PR

  1. Connect
  2. Go to the IBM i Debugger view
  3. Check if the client certificate needs to be downloaded and click on the action to download it
  4. Try debugging

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand added enhancement New feature or request debug Debug client issue (IBM) labels Jul 9, 2024
@sebjulliand sebjulliand added this to the 2.12.0 milestone Jul 9, 2024
@sebjulliand sebjulliand self-assigned this Jul 9, 2024
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand Works as previously, no issues found. 👍

@sebjulliand sebjulliand merged commit ebfde2f into master Jul 10, 2024
1 check passed
@sebjulliand sebjulliand deleted the feature/alwaysSecureDebug branch July 10, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug Debug client issue (IBM) enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants